[ 
https://issues.apache.org/jira/browse/ARTEMIS-4039?focusedWorklogId=815591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815591
 ]

ASF GitHub Bot logged work on ARTEMIS-4039:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/22 09:58
            Start Date: 11/Oct/22 09:58
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #4251:
URL: https://github.com/apache/activemq-artemis/pull/4251#discussion_r992109102


##########
pom.xml:
##########
@@ -1029,7 +1028,7 @@
          <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-databind</artifactId>
-            <version>${jackson-databind.version}</version>
+            <version>${jackson.version}</version>

Review Comment:
   These 2 versions end up differing often enough (and are likely to again 
soon..) that I think its worth keeping the separate version property and 
defaulting it to the others value when they match. I'd undo this change and 
update the property declarations more along the lines of:
   
         <jackson.version>2.13.4</jackson.version>
         <jackson-databind.version>${jackson.version}</jackson-databind.version>





Issue Time Tracking
-------------------

            Worklog Id:     (was: 815591)
    Remaining Estimate: 0h
            Time Spent: 10m

> Upgrade jackson version to 2.13.4
> ---------------------------------
>
>                 Key: ARTEMIS-4039
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4039
>             Project: ActiveMQ Artemis
>          Issue Type: Dependency upgrade
>            Reporter: Domenico Francesco Bruscino
>            Assignee: Domenico Francesco Bruscino
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to