[
https://issues.apache.org/jira/browse/ARTEMIS-4076?focusedWorklogId=821050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821050
]
ASF GitHub Bot logged work on ARTEMIS-4076:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Oct/22 15:33
Start Date: 27/Oct/22 15:33
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4273:
URL: https://github.com/apache/activemq-artemis/pull/4273#discussion_r1007001674
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -244,7 +244,7 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("Attach Listener")) {
return true;
- } else if ((javaVendor.contains("IBM") || isSystemThread) &&
threadName.equals("process reaper")) {
+ } else if ((javaVendor.contains("IBM") || isSystemThread) &&
(threadName.equals("process reaper") || threadName.startsWith("process reaper
(pid"))) {
Review Comment:
It isnt always in the name, it comes and goes.
(EDIT: I misread the original question...yes I meant it, I only added the "
(pid" suffix without the remainder of the string since I wouldnt know the pid
it is actually working for at that point. I had decided not to just do
startsWith("process reaper") since it isnt as precise. But it is more concise
and unlikely to be an issue so I dont mind, changed.)
Issue Time Tracking
-------------------
Worklog Id: (was: 821050)
Time Spent: 1h (was: 50m)
> add JDK 19 run to CI jobs
> -------------------------
>
> Key: ARTEMIS-4076
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4076
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Tests
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Resolve any issues needed and then add a run on Java 19 in the basic push/PR
> etc CI jobs in addition to the existing runs on 11 and 17.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
