[ 
https://issues.apache.org/jira/browse/AMQ-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627158#comment-17627158
 ] 

Matt Pavlovich commented on AMQ-9152:
-------------------------------------

[~cshannon] good catch, definitely on-board with pushing it in now. 

I've been thinking about approaches on cleaning up the unit tests. A number of 
things like breaking some up into separate maven modules (performance-related 
tests, etc) 

Also, junit5 may help from a management perspective.. using @Disabled 
annotation vs rules in the pom. When working in the IDE it takes an extra work 
flow step to check the pom to know if a test is included or not in the maven 
build

> ActiveMQ unit tests are not running all tests
> ---------------------------------------------
>
>                 Key: AMQ-9152
>                 URL: https://issues.apache.org/jira/browse/AMQ-9152
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.17.2
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.18.0, 5.17.3
>
>
> There is an include filter in the pom for activemq-unit-tests that is 
> preventing all tests from running. It's only running tests that end in "Test" 
> so it won't run things like "AdvisoryTests" since there is an s at the end. 
> After changing this I already found one failing test in AdvisoryTests and 
> there will probably be others so once we see what breaks we will need to go 
> fix the tests or ignore them for now and then add a Jira to fix them later as 
> they have likely been broken for a long time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to