[
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822686
]
ASF GitHub Bot logged work on ARTEMIS-4071:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/22 13:20
Start Date: 02/Nov/22 13:20
Worklog Time Spent: 10m
Work Description: TheCycoONE commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011736748
##########
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##########
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
filterChain.doFilter(servletRequest, servletResponse);
if (AuditLogger.isAnyLoggingEnabled()) {
int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything
else must be a failure
- if (status == 200) {
+ if (status < 300) {
Review Comment:
Does 100 continue need to be handled as well - would that ever reach here? I
think in general I would feel better if < 200 was skipped like 300-399.
Issue Time Tracking
-------------------
Worklog Id: (was: 822686)
Time Spent: 40m (was: 0.5h)
> Erroneus audit log messages due to console logouts
> --------------------------------------------------
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
