[
https://issues.apache.org/jira/browse/ARTEMIS-4081?focusedWorklogId=824260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824260
]
ASF GitHub Bot logged work on ARTEMIS-4081:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/22 15:52
Start Date: 08/Nov/22 15:52
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4282:
URL: https://github.com/apache/activemq-artemis/pull/4282#discussion_r1016717824
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java:
##########
@@ -158,6 +178,54 @@ private String getLine(File cmd, String pattern) throws
IOException {
return null;
}
+
+ private void upgradeJDK(String jdkPrefix, String endOfLine, String[]
keepArguments, File tmpFile, File targetFile, File bkp, String...
keepingPrefixes) throws Exception {
+ HashMap<String, String> replaceMatrix = new HashMap<>();
+
+ final HashMap<String, String> currentArguments = new HashMap<>();
Review Comment:
Seems odd to make one final and the other not, both look to be?
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java:
##########
@@ -31,10 +31,20 @@
import java.util.stream.Stream;
import io.airlift.airline.Command;
+import org.apache.activemq.artemis.util.JVMArgumentParser;
@Command(name = "upgrade", description = "Update an artemis instance to the
current artemis.home, keeping all the data and broker.xml. Warning: backup your
instance before using this command and compare the files.")
public class Upgrade extends InstallAbstract {
+ // these are the JVM argumnents we must keep between upgrades:w
Review Comment:
superfluous ":w" at end
Issue Time Tracking
-------------------
Worklog Id: (was: 824260)
Time Spent: 1h 40m (was: 1.5h)
> Upgrade command
> ---------------
>
> Key: ARTEMIS-4081
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4081
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We should add a command to upgrade an instance from an older broker.
> ./artemis upgrade <old-instance> should update the required scripts and files
> to reflect a new broker home.
> The touched files should be backed up for easy recovering in case of failure
> and also for the user to compare eventual configuration they might have done
> on scripts.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
