[ 
https://issues.apache.org/jira/browse/AMQ-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631923#comment-17631923
 ] 

ASF subversion and git services commented on AMQ-9159:
------------------------------------------------------

Commit 837df23be66f9d22e4df61ae40cd70de34e064a7 in activemq's branch 
refs/heads/main from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=837df23be ]

AMQ-9159 - In topic subscriptions only remove nodes from dispatched list if
they match the destination on destination removal


> TopicSubscription should only remove nodes from dispatched list that match 
> destination
> --------------------------------------------------------------------------------------
>
>                 Key: AMQ-9159
>                 URL: https://issues.apache.org/jira/browse/AMQ-9159
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.17.2
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>             Fix For: 5.18.0, 5.17.2
>
>
> I found a minor issue on destination removal from TopicSubscriptions where 
> the dispatched list is cleared but really only nodes that match the removed 
> destination should be removed. There can be multiple destinations associated 
> if it's a wild card consumer. I am putting this as minor as I don't think if 
> it's a real issue in practice as you generally can't remove a destination 
> from an active subscription so since they only get removed when the 
> subscription is closed we would be cleaning up the entire list anyways. 
> Either way i figure it's worth fixing. It's not easy to write a test just for 
> this since closing the sub to remove the dest clears everything anyways (as I 
> said) but there are plenty of existing tests that should exercise the change 
> including the in flight statistics tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to