[ 
https://issues.apache.org/jira/browse/AMQ-9156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634543#comment-17634543
 ] 

ASF subversion and git services commented on AMQ-9156:
------------------------------------------------------

Commit 8554a1464c6471f81ebbcd6c482376ae32cf6808 in activemq's branch 
refs/heads/main from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=8554a1464 ]

(AMQ-9156, AMQ-9167) - Update TopicSubscription to use a new counter for
current dispatched count

The previous way of computing the count of using total dispatched minus
total dequeued didn't work in the case of destination removal and
messages were not acked. The counter is needed as the dispatched list is
optional unlike prefetch subs.


> In flight destination statistics are not properly decremented on Topic sub 
> failure or close
> -------------------------------------------------------------------------------------------
>
>                 Key: AMQ-9156
>                 URL: https://issues.apache.org/jira/browse/AMQ-9156
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.17.2
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.18.0, 5.17.2
>
>
> In flight statistics were enhanced back in AMQ-5837 and I noticed a small 
> edge case issue for Topic subscriptions where the in flight count on the 
> destination the topic subscription was consuming from would not be properly 
> decremented on Topic subscription failure due to dispatch failure or on 
> subscription close. We just need to make sure on failure/close the stats are 
> updated properly (Prefetch subs already do this for queues/durables). I will 
> push a small fix for this and a couple new tests.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to