[
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=833180&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833180
]
ASF GitHub Bot logged work on ARTEMIS-3042:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/22 19:43
Start Date: 13/Dec/22 19:43
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1047631946
##########
artemis-docker/Dockerfile-centos7-11:
##########
@@ -17,12 +17,30 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-centos7-11 .`?
##########
artemis-docker/readme.md:
##########
@@ -1,140 +1,62 @@
# Docker Image Example
This is an example on how you could create your own Docker Image For Apache
-ActiveMQ Artemis based on CentOS or Ubuntu (Eclipse Temurin JDK images).
+ActiveMQ Artemis based on Alpine, CentOS or Ubuntu (Eclipse Temurin JDK
images).
-# Preparing
+# Selecting the image
-Use the script ./prepare-docker.sh as it will copy the docker files under the
-binary distribution.
+This folder contains four different images for hosting your ActiveMQ Artemis
instance in docker
-Below is shown the command to prepare the build of the Docker Image starting
-from the local distribution (from the source codes of ActiveMQ Artemis)
+- Alpine
+- CentOS7
+- Ubuntu 11 with JDK
+- Ubuntu 11 with JRE
Review Comment:
`11` isn't the version of Ubuntu. It is the version of _Java_. Therefore,
the list should probably be:
- Alpine (latest) with JRE 11
- CentOS 7 with JDK 11
- Ubuntu (latest LTS) with JDK 11
- Ubuntu (latest LTS) with JRE 11
##########
artemis-docker/Dockerfile-ubuntu-11:
##########
@@ -17,8 +17,28 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-ubuntu-11 .`?
##########
artemis-docker/Dockerfile-ubuntu-11-jre:
##########
@@ -17,7 +17,30 @@
# ActiveMQ Artemis
+ARG CURRENT_VERSION=2.17.0
+
+FROM eclipse-temurin:11-jdk as builder
+ARG CURRENT_VERSION
+
+ENV VERSION=$CURRENT_VERSION
+
+RUN apt update -y && apt upgrade -y && apt install tree curl -y
+
+ADD ./prepare-docker.sh /bin/prepareDocker
+WORKDIR /root/artemis-build
+COPY ./Dockerfile-alpine .
Review Comment:
Shouldn't this be `COPY ./Dockerfile-ubuntu-11-jre .`?
Issue Time Tracking
-------------------
Worklog Id: (was: 833180)
Time Spent: 3h 10m (was: 3h)
> Official Docker Multistage Build as well as an official Docker image.
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-3042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: John Behm
> Priority: Minor
> Labels: docker,, dockerfile,, kubernetes
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to
> build or to setup Docker image that automatically builds the project from
> source, discards the build container and moves the necessary files over to
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at
> all.
>
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is very
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so
> complex, one will not be able to do this within one month without having gone
> through the whole documentation multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
