[
https://issues.apache.org/jira/browse/ARTEMIS-4136?focusedWorklogId=840666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840666
]
ASF GitHub Bot logged work on ARTEMIS-4136:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/23 15:05
Start Date: 20/Jan/23 15:05
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4338:
URL: https://github.com/apache/activemq-artemis/pull/4338#discussion_r1082674555
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -128,11 +133,17 @@ public void storeLineUp() {
@Override
public void replicationLineUp() {
REPLICATION_LINEUP_UPDATER.incrementAndGet(this);
+ if (logger.isTraceEnabled()) {
Review Comment:
I decide based on how hot the path is. If its 'relatively occasional' I'll
just let it box if it leaves things a lot nicer to read. If its very hot, I'll
gate it. I have no idea in this case :)
Issue Time Tracking
-------------------
Worklog Id: (was: 840666)
Time Spent: 1h 50m (was: 1h 40m)
> Mirror sync replication
> -----------------------
>
> Key: ARTEMIS-4136
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4136
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.28.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I'm adding an option sync=true|false on mirror.
> It will be possible to configure a mirror as this:
> <broker-connections>
> <amqp-connection uri="tcp://test1:111" name="test1"
> retry-interval="333" reconnect-attempts="33" user="testuser"
> password="testpassword">
> <mirror sync="true"/>
> </amqp-connection
> </broker-connection>
> if sync is set to true, any client blocking operation would wait a mirror
> callback.
> With that option set, any blocking operation on the broker will wait a mirror
> roundtrip:
> tx.commit(), session.send (non transactional). client.ack (when configured as
> sync).
> Notice that in AMQP client dispositions are always asynchronous, hence it's
> only possible to sync acks if using transactional for AMQP.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
