[
https://issues.apache.org/jira/browse/ARTEMIS-4136?focusedWorklogId=841129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841129
]
ASF GitHub Bot logged work on ARTEMIS-4136:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/23 13:50
Start Date: 23/Jan/23 13:50
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4338:
URL: https://github.com/apache/activemq-artemis/pull/4338#discussion_r1084080398
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -2447,6 +2447,14 @@
</xsd:documentation>
</xsd:annotation>
</xsd:attribute>
+ <xsd:attribute name="sync" type="xsd:boolean" use="optional"
default="true">
+ <xsd:annotation>
+ <xsd:documentation>
+ If this is true, producers will be waiting a response from the
mirror before the sync is finished.
+ This is false by default.
Review Comment:
Is there a simple test for this type of default that could be updated to
check this value? I notice no test needed to change when you updated it, which
probably explains how it came to be wrong without notice to start with.
Issue Time Tracking
-------------------
Worklog Id: (was: 841129)
Time Spent: 4h (was: 3h 50m)
> Mirror sync replication
> -----------------------
>
> Key: ARTEMIS-4136
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4136
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.28.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> I'm adding an option sync=true|false on mirror.
> It will be possible to configure a mirror as this:
> <broker-connections>
> <amqp-connection uri="tcp://test1:111" name="test1"
> retry-interval="333" reconnect-attempts="33" user="testuser"
> password="testpassword">
> <mirror sync="true"/>
> </amqp-connection
> </broker-connection>
> if sync is set to true, any client blocking operation would wait a mirror
> callback.
> With that option set, any blocking operation on the broker will wait a mirror
> roundtrip:
> tx.commit(), session.send (non transactional). client.ack (when configured as
> sync).
> Notice that in AMQP client dispositions are always asynchronous, hence it's
> only possible to sync acks if using transactional for AMQP.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
