[
https://issues.apache.org/jira/browse/ARTEMIS-4132?focusedWorklogId=841181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841181
]
ASF GitHub Bot logged work on ARTEMIS-4132:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/23 16:39
Start Date: 23/Jan/23 16:39
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4342:
URL: https://github.com/apache/activemq-artemis/pull/4342#discussion_r1084289208
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java:
##########
@@ -1115,8 +1116,15 @@ public Consumer init(ProtonServerSenderContext
senderContext) throws Exception {
} else {
// if not we look up the address
AddressQueryResult addressQueryResult = null;
+
+ // Set this to the broker configured default for the address
prior to the lookup so that
+ // an auto create will actually use the configured defaults.
The actual query result will
+ // contain the true answer on what routing type the address
actually has though.
+ routingTypeToUse =
sessionSPI.getDefaultRoutingType(addressToUse);
+ routingTypeToUse = routingTypeToUse == null ?
ActiveMQDefaultConfiguration.getDefaultRoutingType() : routingTypeToUse;
Review Comment:
Agree to disagree
Issue Time Tracking
-------------------
Worklog Id: (was: 841181)
Time Spent: 0.5h (was: 20m)
> broker uses anycast for amqp destination which is configured as multicast
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-4132
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4132
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.27.1
> Reporter: Erwin Dondorp
> Priority: Major
> Attachments: Dockerfile.recv, Dockerfile.send, recv.py, send.py
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> using:
> * broker configured with default-address-routing-type=MULTICAST (and
> default-queue-routing-type=MULTICAST)
> * clients built with python-qpid-proton, but we have seen the same effect
> with other amqp clients
> When a client is publishing to a new address, the address is created with
> routing type MULTICAST. this is ok.
> When a client is subscribing to a new address, the address is created with
> routing type ANYCAST, which is unexpected.
> To repeat:
> * create plain broker using {{bin/artemis create --allow-anonymous --user
> admin --password admin broker1}}
> * (optional) adjust {{broker1/etc/bootstrap.xml}} and/or adjust
> {{broker1/etc/jolokia-access.xml}} when the broker console can otherwise not
> be used/reached.
> * update {{broker.xml}}: add these 2 lines to the {{address-settings}} for
> '{{#}}'
> {{<default-queue-routing-type>MULTICAST</default-queue-routing-type>}}
> {{<default-address-routing-type>MULTICAST</default-address-routing-type>}}
> * start broker with {{broker1/bin/artemis run}}
> * adjust the broker address in the 2 python files
> * use supplied docker files to build and run a sender and/or a receiver
> scenario 1:
> run only the broker and the sender
> see address '{{demoaddress}}' appear as multicast address
> any messages will disappear as expected because there is no consumer
> scenario 2:
> run only the broker and the receiver
> see address '{{demoaddress}}' appear as anycast (unexpected) address
> a queue with the same name is created under it (consistent)
> remove the address '{{demoaddress}}' between runs because the effect only
> appears for new addresses
> see the attached files
> [~jbertram]: as discussed in the mailing list
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
