[
https://issues.apache.org/jira/browse/ARTEMIS-4189?focusedWorklogId=848376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848376
]
ASF GitHub Bot logged work on ARTEMIS-4189:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/23 15:19
Start Date: 01/Mar/23 15:19
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4385:
URL:
https://github.com/apache/activemq-artemis/pull/4385#issuecomment-1450326728
I also think it shouldn't be resolving IPs.... a hostname is a hostname...
what's the point of having two hostnames pointing to the same IP and
considering it the same thing?
Issue Time Tracking
-------------------
Worklog Id: (was: 848376)
Time Spent: 1.5h (was: 1h 20m)
> NettyConnection.isSameTarget() should compare host names by IPs
> ---------------------------------------------------------------
>
> Key: ARTEMIS-4189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4189
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The method just compares the host names using string equals. However when one
> host name is in IP form (like "10.7.2.2") it should try to resolve the
> addresses of the host name and make sure they are equal if one of the IP
> addresses matches. Otherwise it may return wrong comparison result.
> Also when comparing localhost it should take care of the case where the host
> is absent from the transport configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
