[
https://issues.apache.org/jira/browse/AMQ-8316?focusedWorklogId=850849&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850849
]
ASF GitHub Bot logged work on AMQ-8316:
---------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/23 10:07
Start Date: 14/Mar/23 10:07
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #988:
URL: https://github.com/apache/activemq/pull/988#discussion_r1135294050
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public void setWaitForSlaveTimeout(long waitForSlaveTimeout) {
this.waitForSlaveTimeout = waitForSlaveTimeout;
}
/**
- * Get the passiveSlave
- * @return the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
*/
+ @Deprecated(forRemoval = true)
public boolean isPassiveSlave() {
return this.passiveSlave;
}
/**
- * Set the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public void setWaitForSlaveTimeout(long waitForSlaveTimeout) {
this.waitForSlaveTimeout = waitForSlaveTimeout;
}
/**
- * Get the passiveSlave
- * @return the passiveSlave
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
+ */
+ @Deprecated(forRemoval = true)
public boolean isWaitForSlave() {
return waitForSlave;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setWaitForSlave(boolean waitForSlave) {
this.waitForSlave = waitForSlave;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public long getWaitForSlaveTimeout() {
return this.waitForSlaveTimeout;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
Review Comment:
```suggestion
* @deprecated this method will be renamed to not use slave wording
```
##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -2901,49 +2902,73 @@ public void setSslContext(SslContext sslContext) {
this.sslContext = sslContext;
}
+ /**
+ * Deprecated: this method will be renamed to not use slave wording
+ */
+ @Deprecated(forRemoval = true)
public boolean isShutdownOnSlaveFailure() {
return shutdownOnSlaveFailure;
}
/**
+ * Deprecated: this method will be renamed to not use slave wording
+ *
* @org.apache.xbean.Property
propertyEditor="org.apache.activemq.util.BooleanEditor"
*/
+ @Deprecated(forRemoval = true)
public void setShutdownOnSlaveFailure(boolean shutdownOnSlaveFailure) {
this.shutdownOnSlaveFailure = shutdownOnSlaveFailure;
}
+ /**
+ * Deprecated: it will be removed as it should not be used directly.
Review Comment:
```suggestion
* @deprecated it will be removed as it should not be used directly.
```
Issue Time Tracking
-------------------
Worklog Id: (was: 850849)
Time Spent: 1.5h (was: 1h 20m)
> Remove deprecated BrokerService methods
> ----------------------------------------
>
> Key: AMQ-8316
> URL: https://issues.apache.org/jira/browse/AMQ-8316
> Project: ActiveMQ
> Issue Type: Sub-task
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.18.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Legacy BrokerService methods are unused and should be removed
> Methods targeted for removal:
> isWaitForSlave()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
