[
https://issues.apache.org/jira/browse/AMQNET-831?focusedWorklogId=852103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852103
]
ASF GitHub Bot logged work on AMQNET-831:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/23 19:49
Start Date: 21/Mar/23 19:49
Worklog Time Spent: 10m
Work Description: Jefwillems commented on code in PR #86:
URL: https://github.com/apache/activemq-nms-amqp/pull/86#discussion_r1143918797
##########
test/Apache-NMS-AMQP-Test/Integration/AmqpAcknowledgmentsIntegrationTest.cs:
##########
Review Comment:
You're right, i was stupidly following the example i used to test the change
locally. i updated the code to simplify it, and only use nack, instead of both.
Issue Time Tracking
-------------------
Worklog Id: (was: 852103)
Remaining Estimate: 23.5h (was: 23h 40m)
Time Spent: 0.5h (was: 20m)
> Allow extra AckTypes when using IndividualAcknowledge
> -----------------------------------------------------
>
> Key: AMQNET-831
> URL: https://issues.apache.org/jira/browse/AMQNET-831
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: AMQP-2.0.0
> Environment: Tested with apache artemis (from the latest image on
> quay.io/artemiscloud/activemq-artemis-broker)
> Reporter: Jef Willems
> Priority: Major
> Labels: features, pull-request-available
> Original Estimate: 24h
> Time Spent: 0.5h
> Remaining Estimate: 23.5h
>
> I wrote a pull request to allow acknowledging messages with different
> AckType's
> When using individual acknowledgement, the current setup only accepts
> MODIFIED_FAILED_UNDELIVERABLE as a negative ack, the pull request allows to
> use MODIFIED_FAILED, REJECTED as ack types. This way the client can
> automatically use broker redelivery configurations.
> The client library also is more in line with the qpid-jms counterpart when
> implementing this change:
> [https://github.com/apache/qpid-jms/blob/main/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpConsumer.java#L323]
>
> The pull request can be found here:
> https://github.com/apache/activemq-nms-amqp/pull/86
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
