[
https://issues.apache.org/jira/browse/ARTEMIS-4206?focusedWorklogId=853710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853710
]
ASF GitHub Bot logged work on ARTEMIS-4206:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/23 14:35
Start Date: 29/Mar/23 14:35
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1152045934
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/RefCountMessage.java:
##########
@@ -49,6 +93,28 @@ public int getDurableCount() {
return DURABLE_REF_COUNT_UPDATER.get(this);
}
+ /** Sub classes may mark fired=true when they were explicitly called.
+ * E.g large message removed the file upon cancellation */
+ protected void markFired() {
+ fired = true;
Review Comment:
if the system called the fire method directly, say, a cancellation from a
bad producer, there's no need to call the fire event again on countDown...
(which might not actually happen since the message is going to be GCed).
I need the variable in the status as well as I can't have access to the
message from the status.
Issue Time Tracking
-------------------
Worklog Id: (was: 853710)
Time Spent: 1h (was: 50m)
> Unreferenced AMQP Large Messages are not removed
> ------------------------------------------------
>
> Key: ARTEMIS-4206
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4206
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Say you crashed the server after the ack, and before the file.remove, and the
> journal. record removal.
> The AMQP Large Message may not be removed right away, requiring a restart of
> the broker.
> At this point this is really caused by ARTEMIS-4193 and only affected 2.29.0
> and no previous versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
