[
https://issues.apache.org/jira/browse/ARTEMIS-4206?focusedWorklogId=854208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854208
]
ASF GitHub Bot logged work on ARTEMIS-4206:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 14:58
Start Date: 31/Mar/23 14:58
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1154583919
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java:
##########
@@ -344,4 +344,7 @@ public interface ActiveMQClientLogger {
@LogMessage(id = 214033, value = "Cannot resolve host ", level =
LogMessage.Level.ERROR)
void unableToResolveHost(UnknownHostException e);
+
+ @LogMessage(id = 214034, value = "{} is being garbage collected without
removing its resources.:\nlocations:\n{}", level = LogMessage.Level.INFO)
+ void debugMessageNotReleased(String clazz, String debugString);
Review Comment:
I hadnt actually noticed that those methods are defined in the Message
interface, since RefCountMessage doesnt actually indicate it implements
anything itself...but things subclass it to effectively implement the Message
methods, which makes it rather hard to see whats using it and what the original
impl is when the Message method is being overridden in various places.
Issue Time Tracking
-------------------
Worklog Id: (was: 854208)
Time Spent: 4h 10m (was: 4h)
> Unreferenced AMQP Large Messages are not removed
> ------------------------------------------------
>
> Key: ARTEMIS-4206
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4206
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.29.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Say you crashed the server after the ack, and before the file.remove, and the
> journal. record removal.
> The AMQP Large Message may not be removed right away, requiring a restart of
> the broker.
> At this point this is really caused by ARTEMIS-4193 and only affected 2.29.0
> and no previous versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
