[ 
https://issues.apache.org/jira/browse/ARTEMIS-4292?focusedWorklogId=863205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863205
 ]

ASF GitHub Bot logged work on ARTEMIS-4292:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/23 09:11
            Start Date: 01/Jun/23 09:11
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #4497:
URL: https://github.com/apache/activemq-artemis/pull/4497#discussion_r1212843572


##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java:
##########
@@ -575,6 +575,9 @@ public void testDefaults() {
       assertTrue(metricsConfiguration.isJvmGc());
       assertTrue(metricsConfiguration.isJvmThread());
       assertTrue(metricsConfiguration.isNettyPool());
+      assertTrue(metricsConfiguration.isFileDescriptors());

Review Comment:
   Should `testMetrics` be updated?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 863205)
    Time Spent: 20m  (was: 10m)

> Support additional Micrometer system metrics
> --------------------------------------------
>
>                 Key: ARTEMIS-4292
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4292
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The broker already supports optional metrics for the JVM and Netty, but 
> Micrometer has a number of other metrics which would be useful to support as 
> well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to