[ 
https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=863409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863409
 ]

ASF GitHub Bot logged work on ARTEMIS-3042:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/23 08:57
            Start Date: 02/Jun/23 08:57
    Worklog Time Spent: 10m 
      Work Description: amarkevich commented on code in PR #4307:
URL: https://github.com/apache/activemq-artemis/pull/4307#discussion_r1214111564


##########
artemis-docker/prepare-docker.sh:
##########
@@ -181,10 +163,9 @@ if [ ! -d "${ARTEMIS_DIST_DIR}/docker" ]; then
   mkdir "${ARTEMIS_DIST_DIR}/docker"
 fi
 
-cp ./Dockerfile-* "$ARTEMIS_DIST_DIR/docker"
 cp ./docker-run.sh "$ARTEMIS_DIST_DIR/docker"
 
 echo "Docker file support files at:"
 tree "$ARTEMIS_DIST_DIR/docker"

Review Comment:
   'tree' command in L188 will cause build error since not available in build 
stage. I propose to remove it like done in 
https://github.com/apache/activemq-artemis/pull/4453/files#diff-09d0fd7b380274547af0cdaf1cb41c22b3990dfed9848b560e9d9f77b97fb204L188
   or replace with 'ls -l'





Issue Time Tracking
-------------------

    Worklog Id:     (was: 863409)
    Time Spent: 10h 20m  (was: 10h 10m)

> Official Docker Multistage Build as well as an official Docker image.
> ---------------------------------------------------------------------
>
>                 Key: ARTEMIS-3042
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3042
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: John Behm
>            Priority: Minor
>              Labels: docker,, dockerfile,, kubernetes
>          Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> It would be rather convenient to get people up and running with an easy to 
> build or to setup Docker image that automatically builds the project from 
> source, discards the build container and moves the necessary files over to 
> the final container that can simply be started.
> The current docker image build is not really user firendly or convenient at 
> all.
>  
> https://github.com/apache/activemq-artemis/tree/master/artemis-docker
> The whole setup process of artemis in a containerized environment is  very 
> far from even good.
> The hurdle of using this software is gigantic, as the configuration is so 
> complex, one will not be able to do this within one month without having gone 
> through the whole documentation multiple times.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to