[
https://issues.apache.org/jira/browse/ARTEMIS-4184?focusedWorklogId=865763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-865763
]
ASF GitHub Bot logged work on ARTEMIS-4184:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/23 10:27
Start Date: 15/Jun/23 10:27
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on code in PR #4382:
URL: https://github.com/apache/activemq-artemis/pull/4382#discussion_r1230794849
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
##########
@@ -4586,9 +4586,12 @@ private void deployReloadableConfigFromConfiguration()
throws Exception {
for (BridgeConfiguration newBridgeConfig :
configuration.getBridgeConfigurations()) {
newBridgeConfig.setParentName(newBridgeConfig.getName());
Bridge existingBridge =
clusterManager.getBridges().get(newBridgeConfig.getParentName());
+ if (existingBridge == null) {
+ existingBridge =
clusterManager.getBridges().get(newBridgeConfig.getParentName() + "-0");
Review Comment:
@clebertsuconic
I agree, that really wasn't nice. I was using the concatenation there
because concurrent bridges get named uniquely to be manageable by appending -0,
-1 and so on to their name. At this point that has yet to happen to the
newBridge.
I made some changes here and also rebased against main, hope it's looking
better.
Issue Time Tracking
-------------------
Worklog Id: (was: 865763)
Time Spent: 1h (was: 50m)
> Bidges with concurrency not checked/cleared properly on config reload
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-4184
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4184
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Bidges with concurrency not checked/cleared properly on config reload
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
