[
https://issues.apache.org/jira/browse/ARTEMIS-4346?focusedWorklogId=869340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869340
]
ASF GitHub Bot logged work on ARTEMIS-4346:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/23 14:23
Start Date: 05/Jul/23 14:23
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4536:
URL: https://github.com/apache/activemq-artemis/pull/4536#discussion_r1253189512
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java:
##########
@@ -91,8 +90,6 @@ public AbstractStompClientConnection(URI uri) throws
Exception {
transport.setTransportListener(new StompTransportListener());
transport.connect();
- Wait.waitFor(() -> transport.isConnected(), 1000);
Review Comment:
I could have replaced this with the [parent] Wait class from
artemis-unit-test-support, but since the transport connect is actually
synchronous it didnt seem needed and I removed it instead.
Issue Time Tracking
-------------------
Worklog Id: (was: 869340)
Time Spent: 20m (was: 10m)
> move stomp test-client into systest support module
> --------------------------------------------------
>
> Key: ARTEMIS-4346
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4346
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Tests
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Move the stomp test-client bits into the systest support module so it can be
> used easily from other systest modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
