[
https://issues.apache.org/jira/browse/ARTEMIS-4338?focusedWorklogId=869374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869374
]
ASF GitHub Bot logged work on ARTEMIS-4338:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/23 16:03
Start Date: 05/Jul/23 16:03
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4530:
URL: https://github.com/apache/activemq-artemis/pull/4530#discussion_r1253329624
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java:
##########
@@ -243,6 +243,12 @@ protected void decode(ChannelHandlerContext ctx, ByteBuf
in, List<Object> out) t
ctx.flush();
}
+ @Override
+ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
+
ActiveMQServerLogger.LOGGER.failureDuringProtocolHandshake(ctx.channel().remoteAddress().toString(),
cause);
+ ctx.close();
Review Comment:
You mean something like this?
```java
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable
cause) {
try {
ActiveMQServerLogger.LOGGER.failureDuringProtocolHandshake(ctx.channel().remoteAddress().toString(),
cause);
} finally {
ctx.close();
}
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 869374)
Time Spent: 1h (was: 50m)
> STOMP inoperable w/resource audit logging enabled
> -------------------------------------------------
>
> Key: ARTEMIS-4338
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4338
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
> Affects Versions: 2.29.0
> Reporter: Otavio Rodolfo Piske
> Assignee: Justin Bertram
> Priority: Blocker
> Attachments: camel-stomp-test-debug-2.28.0.log,
> camel-stomp-test-debug-2.29.0.log
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Recently we tried upgrading to Artemis 2.29, but when doing so our
> integration tests started to fail. No code was changed as part of the upgrade.
> With 2.29, the connection seems to fail due to a connection timeout:
>
> {noformat}
> 2023-06-29 07:51:40,739 [Impl$6@b91d8c4)] WARN server
> - AMQ222067: Connection failure has been detected: AMQ229014: Did not
> receive data from /127.0.0.1:50934 within the 60000ms connection TTL. The
> connection will now be closed. [code=CONNECTION_TIMEDOUT]{noformat}
>
> I wasn't able to determine the problem, so I am attaching the debug logs for
> an execution with 2.28 and another with 2.29.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)