[ 
https://issues.apache.org/jira/browse/ARTEMIS-4350?focusedWorklogId=869603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-869603
 ]

ASF GitHub Bot logged work on ARTEMIS-4350:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jul/23 15:35
            Start Date: 06/Jul/23 15:35
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on PR #4541:
URL: 
https://github.com/apache/activemq-artemis/pull/4541#issuecomment-1623890430

   I do believe this will break compatibility for users who upgrade and also 
have existing MQTT subscriptions and a non-default wildcard configuration 
(which is fairly common among folks who use the broker mainly for MQTT).
   
   Furthermore, I'm not entirely sure this is actually more consistent overall. 
Using the configured delimiter instead of `.` is certainly more consistent with 
MQTT syntax, but the name of the queue is an internal implementation detail and 
`.` characters are used in other places for queue names so now this name is 
inconsistent with that.
   
   I think this should probably just stay the way it is.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 869603)
    Time Spent: 50m  (was: 40m)

> MQTT queue creation does not honor the delimiter and always uses '.'
> --------------------------------------------------------------------
>
>                 Key: ARTEMIS-4350
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4350
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: MQTT
>    Affects Versions: 2.29.0
>            Reporter: Erwin Dondorp
>            Priority: Minor
>         Attachments: 1.png, 2.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> When subscribing using an MQTT client on an address, a subscription queue is 
> created.
> For MQTT, the subscription-queue has a name that is constructed using the 
> client-id and the address-name. The parts are always joined using the {{.}} 
> character.
> It is more consistent when the _delimiter_ character is used for that.
> a PR will be added
> using {{/}} as separator, before:
> !1.png!
> using {{/}} as separator, after:
> !2.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to