[
https://issues.apache.org/jira/browse/ARTEMIS-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741708#comment-17741708
]
Gary Tully edited comment on ARTEMIS-4356 at 7/10/23 5:19 PM:
--------------------------------------------------------------
@[michaelandrepearce|https://github.com/apache/activemq-artemis/commits?author=michaelandrepearce]
any chance you have memory of 2017, it looks like the .* [1] regexp is a
little greedy. Note the little test in the description of this issue, does it
ring any bell as to expectations?
from what I know, test.# should match "test" and "test.a" but not "testing.a" ?
there seems to be some history here.
[1]
[https://github.com/apache/activemq-artemis/commit/e9eaa7d#diff-c080f58d1810937d61cced308ce9782b479b27bb3a3a20a6cc4e78b4b31f674bR33]
was (Author: gtully):
@[michaelandrepearce|https://github.com/apache/activemq-artemis/commits?author=michaelandrepearce]
any chance you have memory of 2017, it looks like the .* regexp is a little
greedy. Note the little test in the description of this issue, does it ring any
bell as to expectations?
from what I know, test.# should match "test" and "test.a" but not "testing.a" ?
there seems to be some history here.
https://github.com/apache/activemq-artemis/commit/e9eaa7d#diff-c080f58d1810937d61cced308ce9782b479b27bb3a3a20a6cc4e78b4b31f674bR33
> address match with wildcards seems to be broken
> -----------------------------------------------
>
> Key: ARTEMIS-4356
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4356
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.29.0
> Reporter: Gary Tully
> Priority: Major
> Fix For: 2.30.0
>
> Attachments: MatchTest.java
>
>
> Using a wildcard address include match in federation, include test.# is too
> lenient which points to a bug in the address settings matcher that is in play.
>
> the attached test shows the problem.
> {{final Match<?> underTest = new Match<>("test.#", null, new
> WildcardConfiguration());}}
> {{Predicate<String> predicate = underTest.getPattern().asPredicate();}}
> {{assertTrue(predicate.test("test.A"));}}
> {{assertFalse(predicate.test("testing.A"));}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
