[ 
https://issues.apache.org/jira/browse/ARTEMIS-4355?focusedWorklogId=870544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870544
 ]

ASF GitHub Bot logged work on ARTEMIS-4355:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jul/23 11:23
            Start Date: 12/Jul/23 11:23
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1261036359


##########
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/zookeeper/CuratorDistributedLockTest.java:
##########
@@ -84,8 +82,6 @@ public void setupEnv() throws Throwable {
       }
       testingServer = new TestingCluster(clusterSpecs);
       testingServer.start();
-      // start waits for quorumPeer!=null but not that it has started...
-      Wait.waitFor(this::ensembleHasLeader);

Review Comment:
   I realise, which is why I mentioned it in my question. What I wondered is 
whether the reason it did so, to wait for _actual startup_, has changed on the 
curator side. If it didn't then you have just removed a step that I expect was 
there for a reason.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 870544)
    Time Spent: 1h 10m  (was: 1h)

> Update Сurator to 5.5.0
> -----------------------
>
>                 Key: ARTEMIS-4355
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4355
>             Project: ActiveMQ Artemis
>          Issue Type: Dependency upgrade
>          Components: clustering
>    Affects Versions: 2.29.0
>            Reporter: Alexey Markevich
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to