[
https://issues.apache.org/jira/browse/ARTEMIS-4354?focusedWorklogId=870859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870859
]
ASF GitHub Bot logged work on ARTEMIS-4354:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/23 20:23
Start Date: 13/Jul/23 20:23
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4546:
URL: https://github.com/apache/activemq-artemis/pull/4546#discussion_r1263019989
##########
artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/ActiveMQXAResourceWrapper.java:
##########
@@ -67,6 +67,15 @@ public ActiveMQXAResourceWrapper(XARecoveryConfig...
xaRecoveryConfigs) {
}
}
+ public void updateRecoveryConfig(XARecoveryConfig... xaRecoveryConfigs) {
+ synchronized (ActiveMQXAResourceWrapper.lock) {
+ if (delegate != null) {
+ delegate = null;
Review Comment:
shouldn't close be called here instead? the previous resource will probably
leak?
isn't there a way to write a test for this?
Issue Time Tracking
-------------------
Worklog Id: (was: 870859)
Time Spent: 0.5h (was: 20m)
> Update the recovery XAResource underlying session
> --------------------------------------------------
>
> Key: ARTEMIS-4354
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4354
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.29.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently when the HA cluster status changes the underlying ClientSession of
> the ActiveMQXAResourceWrapper id not updated.
> Thus if the backup server starts after the initial connection, there is no
> way to update the underlying TransportConfigurations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
