[
https://issues.apache.org/jira/browse/ARTEMIS-4366?focusedWorklogId=871547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871547
]
ASF GitHub Bot logged work on ARTEMIS-4366:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/23 13:02
Start Date: 18/Jul/23 13:02
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4555:
URL: https://github.com/apache/activemq-artemis/pull/4555#discussion_r1266740736
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManager.java:
##########
@@ -125,11 +125,11 @@ public ProtonProtocolManager(ProtonProtocolManagerFactory
factory, ActiveMQServe
routingHandler = new AMQPRoutingHandler(server);
}
- public synchronized ReferenceNodeStore getReferenceIDSupplier() {
+ public synchronized ReferenceNodeStoreFactory getReferenceIDSupplier() {
Review Comment:
It still the ID supplier.
That's a reason why I actually didn't make those methods static. although
one of them can't be made static.
I can rename this as IDSupplier. it would implement the NodeStoreFactory and
return a new instance of NodeStore.
Issue Time Tracking
-------------------
Worklog Id: (was: 871547)
Time Spent: 50m (was: 40m)
> Addresses with multiple subscriptions are not working with Mirroring
> --------------------------------------------------------------------
>
> Key: ARTEMIS-4366
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4366
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The NodeStore will be reused by the two Queues on the same address. Each
> queue should have its own.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
