[
https://issues.apache.org/jira/browse/ARTEMIS-4355?focusedWorklogId=871836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871836
]
ASF GitHub Bot logged work on ARTEMIS-4355:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/23 15:21
Start Date: 19/Jul/23 15:21
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1268235641
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/common/SmokeTestBase.java:
##########
@@ -158,24 +156,6 @@ protected static final void recreateBrokerDirectory(final
String homeInstance) {
recreateDirectory(homeInstance + "/log");
}
-
- public boolean waitForServerToStart(String uri, String username, String
password, long timeout) throws InterruptedException {
- long realTimeout = System.currentTimeMillis() + timeout;
- while (System.currentTimeMillis() < realTimeout) {
- try (ActiveMQConnectionFactory cf =
ActiveMQJMSClient.createConnectionFactory(uri, null)) {
- cf.createConnection(username, password).close();
- System.out.println("server " + uri + " started");
- } catch (Exception e) {
- System.out.println("awaiting server " + uri + " start at ");
- Thread.sleep(500);
- continue;
- }
- return true;
- }
-
- return false;
- }
-
Review Comment:
Is this change actually related to the ZooKeep & Curator upgrade? It looks
like an unrelated removal of an unused method.
##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/common/SmokeTestBase.java:
##########
@@ -158,24 +156,6 @@ protected static final void recreateBrokerDirectory(final
String homeInstance) {
recreateDirectory(homeInstance + "/log");
}
-
- public boolean waitForServerToStart(String uri, String username, String
password, long timeout) throws InterruptedException {
- long realTimeout = System.currentTimeMillis() + timeout;
- while (System.currentTimeMillis() < realTimeout) {
- try (ActiveMQConnectionFactory cf =
ActiveMQJMSClient.createConnectionFactory(uri, null)) {
- cf.createConnection(username, password).close();
- System.out.println("server " + uri + " started");
- } catch (Exception e) {
- System.out.println("awaiting server " + uri + " start at ");
- Thread.sleep(500);
- continue;
- }
- return true;
- }
-
- return false;
- }
-
Review Comment:
Is this change actually related to the ZooKeeper & Curator upgrade? It looks
like an unrelated removal of an unused method.
Issue Time Tracking
-------------------
Worklog Id: (was: 871836)
Time Spent: 2h 40m (was: 2.5h)
> Update Сurator to 5.5.0; Zookeeper 3.8.1
> ----------------------------------------
>
> Key: ARTEMIS-4355
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4355
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
