[ 
https://issues.apache.org/jira/browse/ARTEMIS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17753224#comment-17753224
 ] 

Mike Artz edited comment on ARTEMIS-4306 at 8/11/23 1:26 PM:
-------------------------------------------------------------

Yeah that is really helpful thanks. One thought - so does it makes sense to 
have a class next to {{SecurityStoreImpl}}  called like 
{{SecurityStoreMetrics}} that keeps track of the success & failures. Then a 
reference to {{SecurityStoreMetrics}} can be a property in 
{{{}SecurityStoreImpl{}}}. Similar to how 
{{[QueueMessageMetrics|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueMessageMetrics.java]}}
 is being done.  Even though it is not at the broker level,  
QueueMessageMetrics is kind of similar in that it is also having some metrics 
that Micrometer cant give.


was (Author: JIRAUSER301522):
Yeah that is really helpful thanks. One thought - so does it makes sense to 
have a class next to {{SecurityStoreImpl}}  called like 
{{SecurityStoreMetrics}} that keeps track of the success & failures. Then a 
reference to {{SecurityStoreMetrics}} can be a property in 
{{{}SecurityStoreImpl{}}}. Similar to how 
{{[QueueMessageMetrics|https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueMessageMetrics.java]}}
 is being done.  Even though it is not at the broker level,  
{{QueueMessageMetrics }}is kind of similar in that it is also having some 
metrics that Micrometer cant give.

> Add authn/z metrics
> -------------------
>
>                 Key: ARTEMIS-4306
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4306
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Priority: Major
>
> It would be useful to have metrics for authn/z successes and failures as well 
> as for metrics related to the corresponding caches.
> See this discussion on the users mailing list for more details: 
> https://lists.apache.org/thread/g6ygyo4kb3xhygq8hpw7vsl3l2g5qt92



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to