[
https://issues.apache.org/jira/browse/ARTEMIS-4384?focusedWorklogId=875851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-875851
]
ASF GitHub Bot logged work on ARTEMIS-4384:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/23 17:03
Start Date: 11/Aug/23 17:03
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4574:
URL: https://github.com/apache/activemq-artemis/pull/4574#discussion_r1291595969
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstract.java:
##########
@@ -233,6 +235,9 @@ void saveConnectionInfo(String brokerURL, String user,
String password) {
if (Shell.inShell() && CONNECTION_INFORMATION.get() == null) {
CONNECTION_INFORMATION.set(new ConnectionInformation(brokerURL, user,
password));
System.out.println("CLI connected to broker " + brokerURL + ", user:"
+ user);
+ this.brokerURL = brokerURL;
+ this.user = user;
+ this.password = password;
Review Comment:
There was a scenario where recoverConnect was called. the tryConnect was
called, a failure happened, the user / password/ URI was asked, and then
StatQueue didn't have the proper user.
It's either that, or calling recover at the end (which would be worst).
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstract.java:
##########
@@ -233,6 +235,9 @@ void saveConnectionInfo(String brokerURL, String user,
String password) {
if (Shell.inShell() && CONNECTION_INFORMATION.get() == null) {
CONNECTION_INFORMATION.set(new ConnectionInformation(brokerURL, user,
password));
System.out.println("CLI connected to broker " + brokerURL + ", user:"
+ user);
+ this.brokerURL = brokerURL;
+ this.user = user;
+ this.password = password;
Review Comment:
There was a scenario where recoverConnect was called. the tryConnect was
called, a failure happened, the user / password/ URI was asked, and then
StatQueue didn't have the proper user.
It's either that, or calling recover at the end (which would be worse).
Issue Time Tracking
-------------------
Worklog Id: (was: 875851)
Time Spent: 1h (was: 50m)
> CLI method to verify topology on all the nodes (cluster verify)
> ---------------------------------------------------------------
>
> Key: ARTEMIS-4384
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4384
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Affects Versions: 2.30.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This CLI method will download the topology of a server, and connect to all
> the individual nodes to verify their topology.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
