[
https://issues.apache.org/jira/browse/ARTEMIS-4393?focusedWorklogId=877924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877924
]
ASF GitHub Bot logged work on ARTEMIS-4393:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/23 18:12
Start Date: 23/Aug/23 18:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4582:
URL:
https://github.com/apache/activemq-artemis/pull/4582#issuecomment-1690415066
-1000 on this.. sorry!!!
The whole point of the BundleFactory is not require knowing the
implementation from the Interface, and having the Factory figuring out what to
do.
I don't mind about this reflection here as it's only happening once.. it's
more trouble really.
the framework where this came from is Jboss Logging, where we are doing
exactly what it was done before, except that we did that to fix some licensing
and to be able to use SLF4J. I hate to block a PR from someone but I strongly
disagree with this one man! sorry about that!
Issue Time Tracking
-------------------
Worklog Id: (was: 877924)
Time Spent: 1.5h (was: 1h 20m)
> Explicit logger implementation instantiation
> --------------------------------------------
>
> Key: ARTEMIS-4393
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4393
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.30.0
> Reporter: Alexey Markevich
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> - compilation error instead of runtime exception in case of logger annotation
> processor issue;
> - get rid of java.lang.reflect.* & java.security.* usage for logger case
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
