[
https://issues.apache.org/jira/browse/ARTEMIS-4378?focusedWorklogId=878189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878189
]
ASF GitHub Bot logged work on ARTEMIS-4378:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/23 14:40
Start Date: 24/Aug/23 14:40
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4590:
URL: https://github.com/apache/activemq-artemis/pull/4590#discussion_r1304443770
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/address/FederatedAddress.java:
##########
@@ -310,10 +312,15 @@ private boolean match(AddressInfo addressInfo) {
}
private boolean match(SimpleString address, RoutingType routingType) {
- //Currently only supporting Multicast currently.
+ // only supporting Multicast currently.
if (RoutingType.ANYCAST.equals(routingType)) {
return false;
}
+ if (hasPullConnectionConfig) {
+ // multicast address federation has no local queue to trigger batch
pull requests, a regular fast consumer with credit window is necessary
+ // otherwise the upstream would fill up and block.
Review Comment:
It is probably worth logging something here (debug level probably) that
indicates that a match was rejected because pull consumer was configured and
the core federation doesn't allow a way to have both address and queue
federation when in pull mode. At least then you have a breadcrumb to debug it
when someone complains their address federation is broken.
Issue Time Tracking
-------------------
Worklog Id: (was: 878189)
Time Spent: 20m (was: 10m)
> Federation, ignore address policy when using pull consumer connection
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-4378
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4378
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Federation
> Affects Versions: 2.29.0
> Reporter: Gary Tully
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Using the batching pull consumer from ARTEMIS-4314 is only applicable to
> queue Federation but both policies can be configured in the same federation.
> If consumer window size of zero is configured any address policy should be
> ignored. With address federation there is no local queue to gauge capacity
> and messages will just accumate in the upstream. The concept of a pull
> consumer for address federation does not make any sense.
> This strategy is already adopted for queue Federation configured for
> multicast addresses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
