[
https://issues.apache.org/jira/browse/ARTEMIS-4464?focusedWorklogId=886927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886927
]
ASF GitHub Bot logged work on ARTEMIS-4464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 10:53
Start Date: 24/Oct/23 10:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4652:
URL: https://github.com/apache/activemq-artemis/pull/4652#discussion_r1369974142
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/utils/cliHelper/CLICreate.java:
##########
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils.cliHelper;
+
+import java.io.File;
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.StandardCopyOption;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.activemq.artemis.cli.Artemis;
+import org.junit.Assert;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CLICreate extends BaseCLI {
+
+ public CLICreate() {
+ super();
+ }
Review Comment:
this is not a CLI. It is a replacement for what the maven plugin used to do.
We could make this part of the CLI, but I wasn't so sure about that.
Issue Time Tracking
-------------------
Worklog Id: (was: 886927)
Time Spent: 0.5h (was: 20m)
> Cleanup on Soak and Smoke Tests
> -------------------------------
>
> Key: ARTEMIS-4464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4464
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I did the following cleanup:
> - removed a few not used / ignored tests (DNSSwitchTest is not in use by any
> CI I know any more and it's now vaporware)
> - A lot of tests (too many) were using the maven CLi. I'm now calling the CLI
> from the test
> Keeping only a few that is either using a maven property or downloading jars.
> - removed a few JMX usages and replaced by SimpleManagement (over messaging)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
