[
https://issues.apache.org/jira/browse/ARTEMIS-4513?focusedWorklogId=892364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892364
]
ASF GitHub Bot logged work on ARTEMIS-4513:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/23 15:12
Start Date: 27/Nov/23 15:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4686:
URL: https://github.com/apache/activemq-artemis/pull/4686#discussion_r1406312534
##########
artemis-unit-test-support/src/main/java/org/apache/activemq/artemis/utils/ThreadLeakCheckRule.java:
##########
@@ -295,6 +295,8 @@ private boolean isExpectedThread(Thread thread) {
return true;
} else if (threadName.contains("GC Daemon")) {
return true;
+ } else if
(threadName.contains("org.eclipse.jetty.util.RolloverFileOutputStream")) {
Review Comment:
Isn't this hiding a thread leakage? can't we just close the thread instead?
Issue Time Tracking
-------------------
Worklog Id: (was: 892364)
Time Spent: 20m (was: 10m)
> HTTP request logging not working
> --------------------------------
>
> Key: ARTEMIS-4513
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4513
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Adding the following configuration to {{bootstrap.xml}} (as described in [the
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/web-server.html#request-log])
> doesn't seem to have any impact:
> {code:xml}
> <request-log filename="${artemis.instance}/log/http-access-yyyy_MM_dd.log"
> append="true" extended="true"/>{code}
> The log file is created, but nothing is logged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
