[ https://issues.apache.org/jira/browse/ARTEMIS-4517?focusedWorklogId=892671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892671 ]
ASF GitHub Bot logged work on ARTEMIS-4517: ------------------------------------------- Author: ASF GitHub Bot Created on: 28/Nov/23 16:07 Start Date: 28/Nov/23 16:07 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4692: URL: https://github.com/apache/activemq-artemis/pull/4692#discussion_r1408019909 ########## artemis-server/src/main/java/org/apache/activemq/artemis/core/server/MessageReference.java: ########## @@ -142,4 +142,7 @@ default boolean skipDelivery() { */ long getPersistentSize() throws ActiveMQException; + long getQueueSequence(); Review Comment: just a suggestion! I would just call it getSequence here... Like the reference Queue, since a reference will belong to a queue anyway. Nit-pick probably.. do it if you like the suggestion! Issue Time Tracking ------------------- Worklog Id: (was: 892671) Time Spent: 0.5h (was: 20m) > rollback causes loss of message order if concurrent producers commit out of > order > ---------------------------------------------------------------------------------- > > Key: ARTEMIS-4517 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4517 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Affects Versions: 2.31.0 > Reporter: Gary Tully > Assignee: Gary Tully > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > As part of ARTEMIS-2458, cancel puts messages back onto the queue on sequence > id order, but the sequence id is allocated to producers on message send (via > the message store) and can be unordered w.r.t to a queue view when producer > transactions overlap. > The queue has the correct initial producer order, with out of order > sequenceId. > When messages are cancelled back to the queue they go back in sqeuenceId > order in error, giving a consumer out of order messages on the second or > subsequent delivery attempts. > > each queue needs to retain its own sequence and apply to its reference, such > that messages can be cancelled back and retain the queue order. -- This message was sent by Atlassian Jira (v8.20.10#820010)