[
https://issues.apache.org/jira/browse/ARTEMIS-4523?focusedWorklogId=893710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893710
]
ASF GitHub Bot logged work on ARTEMIS-4523:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/23 10:32
Start Date: 04/Dec/23 10:32
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4700:
URL: https://github.com/apache/activemq-artemis/pull/4700#discussion_r1413668116
##########
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java:
##########
@@ -1817,14 +1804,18 @@ public Response
processRecoverTransactions(TransactionInfo info) throws Exceptio
@Override
public Response processRemoveConnection(ConnectionId id, long
lastDeliveredSequenceId) throws Exception {
//we let protocol manager to handle connection add/remove
- try {
- for (SessionState sessionState : state.getSessionStates()) {
- propagateLastSequenceId(sessionState, lastDeliveredSequenceId);
- }
- protocolManager.removeConnection(state.getInfo(), null);
- } catch (Throwable e) {
- // log
+ for (SessionState sessionState : state.getSessionStates()) {
+ propagateLastSequenceId(sessionState, lastDeliveredSequenceId);
+ }
+ if (state.getInfo() == null || state.getInfo().getClientId() == null)
{
+ // I don't know how we could get to this state, I think it's
impossible
Review Comment:
this is just some sensible defensive programming, I would drop the comment.
for me it is debatable as to whether there is any value in a warn, possibly
debug. What could a user do in this case? And what is the problem, we have not
state to whack!
Issue Time Tracking
-------------------
Worklog Id: (was: 893710)
Time Spent: 1h 10m (was: 1h)
> Failover leaving consumers and producers behind
> -----------------------------------------------
>
> Key: ARTEMIS-4523
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4523
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.31.2
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Failover in OpenWire could leave consumers, producers and internal sessions
> hanging behind.
> If the failover happened in a race condition where the new connection
> (reconnection) happened before the client failure.. you could end with
> consumers without connections.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
