[
https://issues.apache.org/jira/browse/ARTEMIS-4521?focusedWorklogId=893869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893869
]
ASF GitHub Bot logged work on ARTEMIS-4521:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/23 20:22
Start Date: 04/Dec/23 20:22
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on PR #4697:
URL:
https://github.com/apache/activemq-artemis/pull/4697#issuecomment-1839413768
It is not independent, reloading file configuration uses the same method
changed with this PR, i.e
`org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl#destroyDivert()`
which now removes the divert from storage.
After that the config reload runs:
`org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl#recoverStoredDiverts()`
which basically does:
`if (divertWithStoredConfig.isDeleted() &&
adressSettings.config-delete-diverts == FORCE)` -> remove stored divert config
`else` -> recreate divert
So before this change, removing a divert from xml config still left it
active (with some fraction of a second in downtime), provided that
`config-delete-diverts = FORCE` is not set. Default is `OFF` i.e never remove a
stored divert
After this change, removing a divert from xml config removes the divert,
regardless what value "config-delete-diverts" has. It also removes the config
from storage.
I think the change made in this PR makes a lot of sense, both for the JMX
and the file configuration use case. I'm also saying that the address setting
"config-delete-diverts" will no longer have any effect anywhere on anything.
Issue Time Tracking
-------------------
Worklog Id: (was: 893869)
Time Spent: 1h (was: 50m)
> Deleting divert using management API doesn't remove binding from journal
> ------------------------------------------------------------------------
>
> Key: ARTEMIS-4521
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4521
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.31.2
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> After a JMX {{createDivert}} followed by a JMX {{destroyDivert}} followed by
> a broker restart the divert is visible again.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
