[
https://issues.apache.org/jira/browse/ARTEMIS-3474?focusedWorklogId=897981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897981
]
ASF GitHub Bot logged work on ARTEMIS-3474:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/24 08:18
Start Date: 04/Jan/24 08:18
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4728:
URL: https://github.com/apache/activemq-artemis/pull/4728#discussion_r1441457874
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/HAPolicyConfiguration.java:
##########
@@ -21,14 +21,14 @@
public interface HAPolicyConfiguration extends Serializable {
enum TYPE {
- LIVE_ONLY("Live Only"),
+ PRIMARY_ONLY("Primary Only"),
REPLICATED("Replicated"),
REPLICA("Replica"),
- SHARED_STORE_MASTER("Shared Store Master"),
- SHARED_STORE_SLAVE("Shared Store Slave"),
+ SHARED_STORE_PRIMARY("Shared Store Primary"),
+ SHARED_STORE_BACKUP("Shared Store Backup"),
COLOCATED("Colocated"),
- PRIMARY("Primary"),
- BACKUP("Backup");
+ REPLICATION_PRIMARY("Replication Primary w/pluggable quorum voting"),
+ REPLICATION_BACKUP("Replication Backup w/pluggable quorum voting");
Review Comment:
I like your idea of using primary/backup terms for both shared store and
pluggable quorum vote replication. What about to use primary/backup terms for
the replication without pluggable quorum vote too?
Some suggestions:
```
REPLICATED("Replicated") -> REPLICATION_PRIMARY("Replication Primary")
REPLICA("Replica") -> REPLICATION_BACKUP("Replication Backup")
PRIMARY("Primary") -> COORDINATED_REPLICATION_PRIMARY("Coordinated
Replication Primary")
BACKUP("Backup") -> COORDINATED_REPLICATION_BACKUP("Coordinated Replication
Backup")
```
```
REPLICATED("Replicated") -> REPLICATION_PRIMARY("Replication Primary")
REPLICA("Replica") -> REPLICATION_BACKUP("Replication Backup")
PRIMARY("Primary") -> MANAGED_REPLICATION_PRIMARY("Managed Replication
Primary")
BACKUP("Backup") -> MANAGED_REPLICATION_BACKUP("Managed Replication Backup")
```
```
REPLICATED("Replicated") -> REPLICATION_PRIMARY("Replication Primary")
REPLICA("Replica") -> REPLICATION_BACKUP("Replication Backup")
PRIMARY("Primary") -> REPLICATION_WITH_MANAGER_PRIMARY("Replication with
Manager Primary")
BACKUP("Backup") -> REPLICATION_WITH_MANAGER_BACKUP("Replication with
Manager Backup")
```
Issue Time Tracking
-------------------
Worklog Id: (was: 897981)
Time Spent: 1h 40m (was: 1.5h)
> Replace use of non-inclusive terms throughout source code, comments and
> documentation
> -------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3474
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3474
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Andy Taylor
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> this follows up on the ActiveMQ Jira at
> https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The
> conversation is on this Jira and in the forum
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
