[
https://issues.apache.org/jira/browse/ARTEMIS-4554?focusedWorklogId=898777&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898777
]
ASF GitHub Bot logged work on ARTEMIS-4554:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/24 19:39
Start Date: 09/Jan/24 19:39
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4731:
URL: https://github.com/apache/activemq-artemis/pull/4731#discussion_r1446521042
##########
artemis-docker/prepare-docker.sh:
##########
@@ -53,23 +53,23 @@ Well done! Now you can continue with building the Docker
image:
# Go to $ARTEMIS_DIST_DIR
$ cd $ARTEMIS_DIST_DIR
- # For CentOS with full JDK 11
- $ docker build -f ./docker/Dockerfile-centos7-11 -t artemis-centos .
+ # For CentOS with full JDK 17
+ $ docker build -f ./docker/Dockerfile-centos7-17 -t artemis-centos .
- # For Ubuntu with full JDK 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11 -t artemis-ubuntu .
+ # For Ubuntu with full JDK 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21 -t artemis-ubuntu .
- # For Ubuntu with just JRE 11
- $ docker build -f ./docker/Dockerfile-ubuntu-11-jre -t artemis-ubuntu-jre .
+ # For Ubuntu with just JRE 21
+ $ docker build -f ./docker/Dockerfile-ubuntu-21-jre -t artemis-ubuntu-jre .
- # For Alpine with full JDK 17
- $ docker build -f ./docker/Dockerfile-alpine-17 -t artemis-alpine .
+ # For Alpine with full JDK 21
+ $ docker build -f ./docker/Dockerfile-alpine-21 -t artemis-alpine .
- # For Alpine with just JRE 11
- $ docker build -f ./docker/Dockerfile-alpine-11-jre -t artemis-alpine-jre .
+ # For Alpine with just JRE 21
+ $ docker build -f ./docker/Dockerfile-alpine-21-jre -t artemis-alpine-jre .
- # For Ubuntu on Linux ARMv7/ARM64 with full JDK
- $ docker buildx build --platform linux/arm64,linux/arm/v7 --push -t
{your-repository}/apache-artemis:2.17.0-SNAPSHOT -f
./docker/Dockerfile-ubuntu-11 .
+ # Multi-platform for Ubuntu on Linux AMD64 & ARM64/V8 with full JDK
+ $ docker buildx build --platform linux/amd64,linux/arm64/v8 --push -t
{your-repository}/apache-artemis:{your-version} -f
./docker/Dockerfile-ubuntu-21 .
Review Comment:
The reason I chose `linux/arm64/v8` instead of `linux/arm64` is because
that's what is reported for the `eclipse-temurin:21-jdk` [base
image](https://hub.docker.com/layers/library/eclipse-temurin/21-jdk/images/sha256-dd7c71ee2e3564d88178b9cdd8dbe83c337d13bf19d0c3038c6f6b3b33186488?context=explore)
being used in the example. I've also used `--platform linux/amd64,linux/arm64`
in my work on
[ARTEMIS-4556](https://issues.apache.org/jira/browse/ARTEMIS-4556) and it works
fine although `linux/arm64` works fine as well. I'm honestly not sure which one
should be preferred.
Issue Time Tracking
-------------------
Worklog Id: (was: 898777)
Time Spent: 1h 10m (was: 1h)
> Upgrade to latest Java for Docker images
> -----------------------------------------
>
> Key: ARTEMIS-4554
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4554
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)