[
https://issues.apache.org/jira/browse/ARTEMIS-4563?focusedWorklogId=899044&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899044
]
ASF GitHub Bot logged work on ARTEMIS-4563:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/24 18:19
Start Date: 10/Jan/24 18:19
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4737:
URL: https://github.com/apache/activemq-artemis/pull/4737#discussion_r1447760718
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/AutoCreateTest.java:
##########
@@ -381,26 +382,36 @@ public void testCleanupAfterReboot(String protocol,
boolean useDelay) throws Exc
try (Connection connection = cf.createConnection()) {
Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
Queue queue = session.createQueue(QUEUE_NAME);
- MessageProducer producer = session.createProducer(queue);
- producer.send(session.createTextMessage(randomString));
+ Topic topic = session.createTopic(TOPIC_NAME);
+ MessageProducer producer = session.createProducer(null);
+ producer.send(queue, session.createTextMessage(randomString));
+ producer.send(topic, session.createTextMessage(randomString));
}
info =
server.getPostOffice().getAddressInfo(SimpleString.toSimpleString(QUEUE_NAME));
Assert.assertNotNull(info);
Assert.assertTrue(info.isAutoCreated());
+ info =
server.getPostOffice().getAddressInfo(SimpleString.toSimpleString(TOPIC_NAME));
+ Assert.assertNotNull(info);
+ Assert.assertTrue(info.isAutoCreated());
+
server.stop();
try (AssertionLoggerHandler loggerHandler = new
AssertionLoggerHandler()) {
server.start();
- Assert.assertFalse(loggerHandler.findText("AMQ224113")); // this time
around the queue had messages, it has to exist
+ Assert.assertFalse(loggerHandler.matchText("AMQ224113.*" +
QUEUE_NAME)); // this time around the queue had messages, it has to exist
+ Assert.assertTrue(loggerHandler.matchText("AMQ224113.*" +
TOPIC_NAME)); // this time around the queue had messages, it has to exist
Review Comment:
@gemmellr I changed the order of the checks.
Issue Time Tracking
-------------------
Worklog Id: (was: 899044)
Time Spent: 50m (was: 40m)
> Auto created addresses are not removed upon restart
> ---------------------------------------------------
>
> Key: ARTEMIS-4563
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4563
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Auto created addresses without queues are not removed upon restart after
> upgrading to 2.29.0 or any later versions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
