[
https://issues.apache.org/jira/browse/ARTEMIS-4540?focusedWorklogId=900693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900693
]
ASF GitHub Bot logged work on ARTEMIS-4540:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/24 12:24
Start Date: 19/Jan/24 12:24
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4725:
URL: https://github.com/apache/activemq-artemis/pull/4725#discussion_r1458916273
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java:
##########
@@ -285,7 +285,7 @@ public Acceptor createAcceptor(TransportConfiguration info)
{
managementService.registerAcceptor(acceptor, info);
}
} catch (Exception e) {
-
ActiveMQServerLogger.LOGGER.errorCreatingAcceptor(info.getFactoryClassName(),
e);
+ ActiveMQServerLogger.LOGGER.errorCreatingAcceptor(info.toString(), e);
Review Comment:
This seems like it could/should be a separate change.
I'm also not sure logging all the info is that necessary, given the length
it could be and that it often contains credentials (though there does look to
be masking involved here). The underlying cause is being being logged anyway.
The acceptors are required to have names, what about just using that rather
than the factory class name?
Issue Time Tracking
-------------------
Worklog Id: (was: 900693)
Time Spent: 20m (was: 10m)
> NullPointerException during initialization
> ------------------------------------------
>
> Key: ARTEMIS-4540
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4540
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.31.0
> Reporter: Daniel Martin
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {noformat}
> _ _ _
> / \ ____| |_ ___ __ __(_) _____
> / _ \| _ \ __|/ _ \ \/ | |/ __/
> / ___ \ | \/ |_/ __/ |\/| | |\___ \
> /_/ \_\| \__\____|_| |_|_|/___ /
> Apache ActiveMQ Artemis 2.31.0
> 18:58:47,218 INFO [org.apache.activemq.artemis.integration.bootstrap]
> AMQ101000: Starting ActiveMQ Artemis Server version 2.31.0
> 18:58:47,288 INFO [org.apache.activemq.artemis.core.server] AMQ221000: live
> Message Broker is starting with configuration Broker Configuration
> (clustered=false,journalDirectory=data/journal,bindingsDirectory=data/bindings,largeMessagesDirectory=data/large-messages,pagingDirectory=data/paging)
> 18:58:47,371 INFO [org.apache.activemq.artemis.core.server] AMQ221013: Using
> NIO Journal
> 18:58:47,475 INFO [org.apache.activemq.artemis.core.server] AMQ221057:
> Global Max Size is being adjusted to 1/2 of the JVM max size (-Xmx). being
> defined as 1073741824
> 18:58:47,522 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-server]. Adding protocol support for: CORE
> 18:58:47,524 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-amqp-protocol]. Adding protocol support for:
> AMQP
> 18:58:47,524 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-hornetq-protocol]. Adding protocol support
> for: HORNETQ
> 18:58:47,528 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-mqtt-protocol]. Adding protocol support for:
> MQTT
> 18:58:47,528 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-openwire-protocol]. Adding protocol support
> for: OPENWIRE
> 18:58:47,528 INFO [org.apache.activemq.artemis.core.server] AMQ221043:
> Protocol module found: [artemis-stomp-protocol]. Adding protocol support for:
> STOMP
> 18:58:47,664 INFO [org.apache.activemq.artemis.core.server] AMQ221034:
> Waiting indefinitely to obtain live lock
> 18:58:47,664 INFO [org.apache.activemq.artemis.core.server] AMQ221035: Live
> Server Obtained live lock
> 18:58:48,822 INFO [org.apache.activemq.artemis.core.server] AMQ221080:
> Deploying address DLQ supporting [ANYCAST]
> 18:58:48,823 INFO [org.apache.activemq.artemis.core.server] AMQ221003:
> Deploying ANYCAST queue DLQ on address DLQ
> 18:58:48,833 INFO [org.apache.activemq.artemis.core.server] AMQ221080:
> Deploying address ExpiryQueue supporting [ANYCAST]
> 18:58:48,834 INFO [org.apache.activemq.artemis.core.server] AMQ221003:
> Deploying ANYCAST queue ExpiryQueue on address ExpiryQueue
> 18:58:49,081 WARN [org.apache.activemq.artemis.core.server] AMQ222080: Error
> instantiating remoting acceptor
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptorFactory
> java.lang.NullPointerException: null
> at
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> ~[?:?]
> at
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) ~[?:?]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.<init>(MQTTStateManager.java:88)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.getInstance(MQTTStateManager.java:66)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManager.<init>(MQTTProtocolManager.java:86)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory.createProtocolManager(MQTTProtocolManagerFactory.java:51)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.createAcceptor(RemotingServiceImpl.java:271)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.start(RemotingServiceImpl.java:217)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:3488)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:78)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:720)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:610)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.integration.FileBroker.start(FileBroker.java:66)
> [artemis-cli-2.31.0.jar:2.31.0]
> at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:130)
> [artemis-cli-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:219)
> [artemis-cli-2.31.0.jar:2.31.0]
> at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:165)
> [artemis-cli-2.31.0.jar:2.31.0]
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:?]
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> ~[?:?]
> at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
> at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
> [artemis-boot.jar:2.31.0]
> at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61)
> [artemis-boot.jar:2.31.0]
> 18:58:49,098 WARN [org.apache.activemq.artemis.core.server] AMQ222080: Error
> instantiating remoting acceptor
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptorFactory
> java.lang.NullPointerException: null
> at
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)
> ~[?:?]
> at
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) ~[?:?]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.<init>(MQTTStateManager.java:88)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.getInstance(MQTTStateManager.java:66)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManager.<init>(MQTTProtocolManager.java:86)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory.createProtocolManager(MQTTProtocolManagerFactory.java:51)
> ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.createAcceptor(RemotingServiceImpl.java:271)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.start(RemotingServiceImpl.java:217)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:3488)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:78)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:720)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:610)
> [artemis-server-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.integration.FileBroker.start(FileBroker.java:66)
> [artemis-cli-2.31.0.jar:2.31.0]
> at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:130)
> [artemis-cli-2.31.0.jar:2.31.0]
> at
> org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:219)
> [artemis-cli-2.31.0.jar:2.31.0]
> at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:165)
> [artemis-cli-2.31.0.jar:2.31.0]
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:?]
> at
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> ~[?:?]
> at
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
> at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:144)
> [artemis-boot.jar:2.31.0]
> at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:61)
> [artemis-boot.jar:2.31.0]
> 18:58:49,410 INFO [org.apache.activemq.artemis.core.server] AMQ221020:
> Started EPOLL Acceptor at 0.0.0.0:5445 for protocols [HORNETQ,STOMP]
> 18:58:49,498 INFO [org.apache.activemq.artemis.core.server] AMQ221020:
> Started EPOLL Acceptor at 0.0.0.0:5672 for protocols [AMQP]
> 18:58:49,507 INFO [org.apache.activemq.artemis.core.server] AMQ221020:
> Started EPOLL Acceptor at 0.0.0.0:61613 for protocols [STOMP]
> 18:58:49,513 INFO [org.apache.activemq.artemis.core.server] AMQ221007:
> Server is now live
> 18:58:49,518 INFO [org.apache.activemq.artemis.core.server] AMQ221001:
> Apache ActiveMQ Artemis Message Broker version 2.31.0 [0.0.0.0,
> nodeID=cef8fffa-8fc8-11ee-a2f5-0242c0a84004]
> 18:58:49,532 INFO [org.apache.activemq.artemis] AMQ241003: Starting embedded
> web server
> 18:58:50,455 INFO
> [org.apache.activemq.hawtio.branding.PluginContextListener] Initialized
> activemq-branding plugin
> 18:58:50,501 INFO [org.apache.activemq.hawtio.plugin.PluginContextListener]
> Initialized artemis-plugin plugin
> 18:58:50,793 INFO [io.hawt.HawtioContextListener] Initialising hawtio
> services
> 18:58:50,806 INFO [io.hawt.system.ConfigManager] Configuration will be
> discovered via system properties
> 18:58:50,815 INFO [io.hawt.jmx.JmxTreeWatcher] Welcome to Hawtio 2.17.6
> 18:58:50,822 INFO [io.hawt.web.auth.AuthenticationConfiguration] Starting
> hawtio authentication filter, JAAS realm: "activemq" authorized role(s):
> "amq" role principal classes:
> "org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal"
> 18:58:50,855 INFO [io.hawt.web.auth.LoginRedirectFilter] Hawtio
> loginRedirectFilter is using 1800 sec. HttpSession timeout
> 18:58:50,902 INFO [io.hawt.web.proxy.ProxyServlet] Proxy servlet is disabled
> 18:58:50,915 INFO [io.hawt.web.servlets.JolokiaConfiguredAgentServlet]
> Jolokia overridden property: [key=policyLocation,
> value=file:/artemis/instance/etc/jolokia-access.xml]
> 18:58:51,128 INFO [org.apache.activemq.artemis] AMQ241001: HTTP Server
> started at http://0.0.0.0:8161
> 18:58:51,128 INFO [org.apache.activemq.artemis] AMQ241002: Artemis Jolokia
> REST API available at http://0.0.0.0:8161/console/jolokia
> 18:58:51,128 INFO [org.apache.activemq.artemis] AMQ241004: Artemis Console
> available at http://0.0.0.0:8161/console
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
