[ 
https://issues.apache.org/jira/browse/AMQ-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Terrien Jean-Yves updated AMQ-9419:
-----------------------------------
    Description: 
In ActiveMQ
We have the "createContext" methods
{code:java}
createContext() => new ActiveMQContext(createActiveMQConnection())

createContext(userName, password) => return new 
ActiveMQContext(createActiveMQConnection(userName, password))

createContext(userName, password, sessionMode) => return new 
ActiveMQContext(createActiveMQConnection(userName, password), sessionMode)
{code}
 

But for
{code:java}
createContext(int sessionMode) => throw new 
UnsupportedOperationException("createContext() is not supported"){code}
While
{code:java}
createContext(int sessionMode) => return new 
ActiveMQContext(createActiveMQConnection(getUserName(), getPassword()), 
sessionMode){code}
works correctly

Why raise this exception?

Otherwise I suggest changing lines 327 to 332 of ActiveMQConnectionFactory.java
by
{code:java}
     public JMSContext createContext(String userName, String password, int 
sessionMode) {
         try {
             return new ActiveMQContext(createActiveMQConnection(getUserName(), 
getPassword()), sessionMode);
         } catch (JMSException e) {
             throw JMSExceptionSupport.convertToJMSRuntimeException(e);
         }
     }
{code}

  was:
In ActiveMQ
We have the "createContext" methods
{code:java}
createContext() => new ActiveMQContext(createActiveMQConnection())
JcreateContext(userName, password) => return new 
ActiveMQContext(createActiveMQConnection(userName, password))
createContext(userName, password, sessionMode) => return new 
ActiveMQContext(createActiveMQConnection(userName, password), sessionMode)
{code}
 

But for
{code:java}
createContext(int sessionMode) => throw new 
UnsupportedOperationException("createContext() is not supported"){code}
While
{code:java}
createContext(int sessionMode) => return new 
ActiveMQContext(createActiveMQConnection(getUserName(), getPassword()), 
sessionMode){code}
works correctly

Why raise this exception?

Otherwise I suggest changing lines 327 to 332 of ActiveMQConnectionFactory.java
by
{code:java}
     public JMSContext createContext(String userName, String password, int 
sessionMode) {
         try {
             return new ActiveMQContext(createActiveMQConnection(getUserName(), 
getPassword()), sessionMode);
         } catch (JMSException e) {
             throw JMSExceptionSupport.convertToJMSRuntimeException(e);
         }
     }
{code}



> UnsupportedOperationException("createContext() is not supported")
> -----------------------------------------------------------------
>
>                 Key: AMQ-9419
>                 URL: https://issues.apache.org/jira/browse/AMQ-9419
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 6.0.1
>            Reporter: Terrien Jean-Yves
>            Priority: Major
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In ActiveMQ
> We have the "createContext" methods
> {code:java}
> createContext() => new ActiveMQContext(createActiveMQConnection())
> createContext(userName, password) => return new 
> ActiveMQContext(createActiveMQConnection(userName, password))
> createContext(userName, password, sessionMode) => return new 
> ActiveMQContext(createActiveMQConnection(userName, password), sessionMode)
> {code}
>  
> But for
> {code:java}
> createContext(int sessionMode) => throw new 
> UnsupportedOperationException("createContext() is not supported"){code}
> While
> {code:java}
> createContext(int sessionMode) => return new 
> ActiveMQContext(createActiveMQConnection(getUserName(), getPassword()), 
> sessionMode){code}
> works correctly
> Why raise this exception?
> Otherwise I suggest changing lines 327 to 332 of 
> ActiveMQConnectionFactory.java
> by
> {code:java}
>      public JMSContext createContext(String userName, String password, int 
> sessionMode) {
>          try {
>              return new 
> ActiveMQContext(createActiveMQConnection(getUserName(), getPassword()), 
> sessionMode);
>          } catch (JMSException e) {
>              throw JMSExceptionSupport.convertToJMSRuntimeException(e);
>          }
>      }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to