[
https://issues.apache.org/jira/browse/AMQ-9420?focusedWorklogId=901214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901214
]
ASF GitHub Bot logged work on AMQ-9420:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/24 15:03
Start Date: 23/Jan/24 15:03
Worklog Time Spent: 10m
Work Description: cshannon opened a new pull request, #1142:
URL: https://github.com/apache/activemq/pull/1142
This adds a check in case a duplicate ack is passed to the store to make
sure that the subscription statistics (if enabled) for a durable sub do not
have the metrics decremented a second time
I also noticed one small spot where we should probably increase the metrics
for the store after adding to the order index (not before) just in case of
exception and someone doesn't have kahadb configured to shutdown on io exception
Issue Time Tracking
-------------------
Worklog Id: (was: 901214)
Remaining Estimate: 0h
Time Spent: 10m
> KahaDB durable subscription stats can go negative on duplicate acks
> -------------------------------------------------------------------
>
> Key: AMQ-9420
> URL: https://issues.apache.org/jira/browse/AMQ-9420
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.18.3, 6.0.1
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 6.1.0, 5.18.4, 5.17.7, 6.0.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> AMQ-6375 added support for non blocking durable subscription statistics to
> KahaDB to track pending message count and message size metrics. By default
> this is disabled and can be enabled with the enableSubscriptionStatistics
> flag on KahaDB.
> On rare occasions I have noticed that sometimes the metrics may got negative
> or be slightly off. I found an area where it's possible if a duplicate ack
> comes in then in some scenarios the metrics may be deprecated twice. This
> issue only applies to the subscription stats and not the store statistics for
> the overall destination as those stats would only get decremented once when
> the message is removed from the order index.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
