[ 
https://issues.apache.org/jira/browse/AMQ-9420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810020#comment-17810020
 ] 

ASF subversion and git services commented on AMQ-9420:
------------------------------------------------------

Commit 1fce36b3e50ed7254fbdcfc1c57e339c31b9b5e2 in activemq's branch 
refs/heads/activemq-5.18.x from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=1fce36b3e ]

AMQ-9420 - Don't decrement KahaDB durable sub metrics on duplicate ack

This adds a check in case a duplicate ack is passed to the store to make
sure that the subscription statistics (if enabled) for a durable sub do
not have the metrics decremented a second time

(cherry picked from commit 918099cb7ee4c46c9a3ea1d418411444dd00fcec)


> KahaDB durable subscription stats can go negative on duplicate acks
> -------------------------------------------------------------------
>
>                 Key: AMQ-9420
>                 URL: https://issues.apache.org/jira/browse/AMQ-9420
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.18.3, 6.0.1
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 6.1.0, 5.18.4, 5.17.7, 6.0.2
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> AMQ-6375 added support for non blocking durable subscription statistics to 
> KahaDB to track pending message count and message size metrics. By default 
> this is disabled and can be enabled with the enableSubscriptionStatistics 
> flag on KahaDB.
> On rare occasions I have noticed that sometimes the metrics may got negative 
> or be slightly off. I found an area where it's possible if a duplicate ack 
> comes in then in some scenarios the metrics may be deprecated twice. This 
> issue only applies to the subscription stats and not the store statistics for 
> the overall destination as those stats would only get decremented once when 
> the message is removed from the order index.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to