[
https://issues.apache.org/jira/browse/ARTEMIS-1230?focusedWorklogId=903409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903409
]
ASF GitHub Bot logged work on ARTEMIS-1230:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/24 18:14
Start Date: 02/Feb/24 18:14
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4782:
URL: https://github.com/apache/activemq-artemis/pull/4782#discussion_r1476278311
##########
artemis-bom/pom.xml:
##########
@@ -0,0 +1,244 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.33.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-bom</artifactId>
+ <packaging>pom</packaging>
+ <name>ActiveMQ Artemis Bill of Materials</name>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-amqp-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-boot</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>activemq-branding</artifactId>
+ <type>war</type>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-cdi-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-cli</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-console</artifactId>
+ <type>war</type>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client-osgi</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client-all</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-dto</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-features</artifactId>
+ <version>${project.version}</version>
+ <classifier>features</classifier>
+ <type>xml</type>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-hornetq-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-hqclient-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-server</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-service-extensions</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jdbc-store</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-bridge</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client-all</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-client-osgi</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jms-server</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-journal</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-mqtt-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-openwire-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
jakarta equivalent is missing
##########
artemis-bom/pom.xml:
##########
@@ -0,0 +1,244 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.33.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-bom</artifactId>
+ <packaging>pom</packaging>
+ <name>ActiveMQ Artemis Bill of Materials</name>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-amqp-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-boot</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>activemq-branding</artifactId>
+ <type>war</type>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-cdi-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-cli</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-console</artifactId>
+ <type>war</type>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client-osgi</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-core-client-all</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-dto</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-features</artifactId>
+ <version>${project.version}</version>
+ <classifier>features</classifier>
+ <type>xml</type>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-hornetq-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-hqclient-protocol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
-all variant is missing
##########
artemis-parent/pom.xml:
##########
@@ -0,0 +1,2074 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.33.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-parent</artifactId>
+ <packaging>pom</packaging>
+ <name>ActiveMQ Artemis Parent POM</name>
+
+ <properties>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
Review Comment:
Would probably leave these at the root pom, and possibly some or all maven
plugin related version properties (given they can/do sometimes override the
parent and control the plugins used _for_ the root pom), and probably the
enforcer config to verify maven and java versions before anything else is done.
##########
artemis-parent/pom.xml:
##########
@@ -0,0 +1,2074 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.33.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>artemis-parent</artifactId>
+ <packaging>pom</packaging>
+ <name>ActiveMQ Artemis Parent POM</name>
+
+ <properties>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
+
+ <retryTests>false</retryTests>
+ <logging.config>log4j2-tests-config.properties</logging.config>
+ <modular.jdk.surefire.arg>--add-modules java.sql,jdk.unsupported
</modular.jdk.surefire.arg>
+
+ <activemq-artemis-native-version>2.0.0</activemq-artemis-native-version>
+ <karaf.version>4.4.4</karaf.version>
+ <pax.exam.version>4.13.5</pax.exam.version>
+ <commons.config.version>2.9.0</commons.config.version>
+ <commons.lang.version>3.14.0</commons.lang.version>
+ <activemq5-version>5.18.3</activemq5-version>
+ <apache.derby.version>10.15.2.0</apache.derby.version>
+ <commons.beanutils.version>1.9.4</commons.beanutils.version>
+ <commons.logging.version>1.3.0</commons.logging.version>
+ <commons.dbcp2.version>2.11.0</commons.dbcp2.version>
+ <commons.pool2.version>2.12.0</commons.pool2.version>
+ <commons.collections.version>3.2.2</commons.collections.version>
+ <commons.text.version>1.10.0</commons.text.version>
+ <commons.io.version>2.15.1</commons.io.version>
+ <commons.codec.version>1.16.0</commons.codec.version>
+ <fuse.mqtt.client.version>1.16</fuse.mqtt.client.version>
+ <caffeine.version>3.1.8</caffeine.version>
+ <guava.version>33.0.0-jre</guava.version>
+ <hawtio.version>2.17.7</hawtio.version>
+ <jsr305.version>3.0.2</jsr305.version>
+ <jetty.version>10.0.20</jetty.version>
+ <jetty-servlet-api.version>4.0.6</jetty-servlet-api.version>
+ <jgroups.version>5.3.2.Final</jgroups.version>
+ <errorprone.version>2.24.1</errorprone.version>
+ <maven.bundle.plugin.version>5.1.9</maven.bundle.plugin.version>
+ <jib.maven.plugin.version>3.3.2</jib.maven.plugin.version>
+ <versions.maven.plugin.version>2.16.1</versions.maven.plugin.version>
+ <sevntu.checks.version>1.44.1</sevntu.checks.version>
+ <checkstyle.version>10.12.7</checkstyle.version>
+ <mockito.version>5.10.0</mockito.version>
+ <jctools.version>4.0.2</jctools.version>
+ <netty.version>4.1.106.Final</netty.version>
+ <hdrhistogram.version>2.1.12</hdrhistogram.version>
+ <curator.version>5.6.0</curator.version>
+ <zookeeper.version>3.9.1</zookeeper.version>
+ <woodstox.version>4.4.0</woodstox.version>
+ <pem-keystore.version>2.3.0</pem-keystore.version>
+ <!
Issue Time Tracking
-------------------
Worklog Id: (was: 903409)
Time Spent: 4h 50m (was: 4h 40m)
> Create Maven Bill of Materials (BOM)
> ------------------------------------
>
> Key: ARTEMIS-1230
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1230
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Daniel Siviter
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> It's frustrating having to deal with dependency versions so the creation of a
> Bill of Materials will assist with this.
> I'm currently battling with Wildfly Swarm 2017.6.0 overriding to
> v1.1.0.wildfly017. To override the version of Artemis I have to have an entry
> in my POM for every single dependency which is arduous.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)