[
https://issues.apache.org/jira/browse/ARTEMIS-4644?focusedWorklogId=905098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-905098
]
ASF GitHub Bot logged work on ARTEMIS-4644:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/24 16:06
Start Date: 15/Feb/24 16:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4821:
URL:
https://github.com/apache/activemq-artemis/pull/4821#issuecomment-1946418150
I ran the full test suite on the changes. The effective changes are really
just in the 2 classes changed though.
Issue Time Tracking
-------------------
Worklog Id: (was: 905098)
Time Spent: 20m (was: 10m)
> convert some broker-connection tests to use test peer
> -----------------------------------------------------
>
> Key: ARTEMIS-4644
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4644
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: AMQP
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Some of the AMQP Broker Connection tests utilise a vertx-proton based 'mock
> server' to check the broker-connection behaviour. At the time they were added
> these were really the first 'test server' based AMQP tests in the codebase.
> Since then, a larger number of newer tests are now using the ProtonJ2 test
> peer to handle such test verifications. We should convert the earlier tests
> to use the same general approach.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)