[
https://issues.apache.org/jira/browse/ARTEMIS-4657?focusedWorklogId=907424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907424
]
ASF GitHub Bot logged work on ARTEMIS-4657:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/24 21:01
Start Date: 28/Feb/24 21:01
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4833:
URL: https://github.com/apache/activemq-artemis/pull/4833#discussion_r1506660176
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -1562,7 +1562,7 @@ public final Object getObjectProperty(String key) {
return getAMQPUserID();
case MessageUtil.CORRELATIONID_HEADER_NAME_STRING:
if (properties != null && properties.getCorrelationId() != null) {
- return
AMQPMessageIdHelper.INSTANCE.toCorrelationIdString(properties.getCorrelationId());
+ return
AMQPMessageIdHelper.INSTANCE.toCorrelationIdStringOrBytes(properties.getCorrelationId());
Review Comment:
This does change the semantics of the original `toCorrelationIdString`. Now
if the ID is a `Binary` it will return a `byte[]` instead of a `String`. If we
want to support compatibility between JMS clients as well as other protocols
which use `byte[]` correlation IDs I don't see a way around a change like this.
Currently no JMS client is compatible with another using
`setJMSCorrelationIDAsBytes`.
Issue Time Tracking
-------------------
Worklog Id: (was: 907424)
Time Spent: 40m (was: 0.5h)
> Support correlation ID compatibility between JMS clients
> --------------------------------------------------------
>
> Key: ARTEMIS-4657
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4657
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently there are some use-cases with both {{String}} and {{byte[]}} values
> of JMS correlation ID that don't work between Core, OpenWire, and AMQP. We
> should support as many as possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
