[ 
https://issues.apache.org/jira/browse/ARTEMIS-4655?focusedWorklogId=907704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-907704
 ]

ASF GitHub Bot logged work on ARTEMIS-4655:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/24 01:46
            Start Date: 01/Mar/24 01:46
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4830:
URL: https://github.com/apache/activemq-artemis/pull/4830#discussion_r1508389800


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java:
##########
@@ -86,6 +87,9 @@ public MetricsManager(String brokerName,
          if (metricsConfiguration.isUptime()) {
             new UptimeMetrics().bindTo(meterRegistry);
          }
+         if (metricsConfiguration.isLogging()) {
+            new Log4j2Metrics().bindTo(meterRegistry);
+         }

Review Comment:
   See the latest update.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 907704)
    Time Spent: 1h  (was: 50m)

> Report logging metrics
> ----------------------
>
>                 Key: ARTEMIS-4655
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4655
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> External systems (e.g. Prometheus & Grafana) can consume metrics to visualize 
> and monitor the health and performance of the broker. These systems often 
> support configurable alerts to inform administrators of problems (e.g. long 
> GC pauses, message accumulation, etc.). It may be useful to configure alerts 
> for {{ERROR}} or {{WARN}} events in the log which may go unnoticed otherwise. 
> The 
> [Log4j2Metrics.java|https://github.com/micrometer-metrics/micrometer/blob/main/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging/Log4j2Metrics.java]
>  provided by Micrometer will report metrics for each logging category so 
> administrators can see when unexpected events occur.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to