[ https://issues.apache.org/jira/browse/ARTEMIS-4657?focusedWorklogId=908590&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908590 ]
ASF GitHub Bot logged work on ARTEMIS-4657: ------------------------------------------- Author: ASF GitHub Bot Created on: 06/Mar/24 15:36 Start Date: 06/Mar/24 15:36 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4833: URL: https://github.com/apache/activemq-artemis/pull/4833#discussion_r1514702597 ########## artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java: ########## @@ -590,9 +590,9 @@ private static ActiveMQMessage toAMQMessage(MessageReference reference, } amqMsg.setCommandId(commandId); - final SimpleString corrId = getObjectProperty(coreMessage, SimpleString.class, OpenWireConstants.JMS_CORRELATION_ID_PROPERTY); - if (corrId != null) { - amqMsg.setCorrelationId(corrId.toString()); + final Object correlationID = coreMessage.getCorrelationID(); + if (correlationID != null) { + amqMsg.setCorrelationId(correlationID.toString()); Review Comment: So the expectation is an Openwire client will now always receive null if a non-Openwire sender sends byte[], as opposed to previously getting a string-encoding of the value if the sender was AMQP? Seems like it we are going to change it, it could instead try sending the bytes as a string, if they are UTF-8...or keep doing what it did before for AMQP. Issue Time Tracking ------------------- Worklog Id: (was: 908590) Time Spent: 2h 40m (was: 2.5h) > Support correlation ID compatibility between JMS clients > -------------------------------------------------------- > > Key: ARTEMIS-4657 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4657 > Project: ActiveMQ Artemis > Issue Type: Improvement > Reporter: Justin Bertram > Assignee: Justin Bertram > Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently there are some use-cases with both {{String}} and {{byte[]}} values > of JMS correlation ID that don't work between Core, OpenWire, and AMQP. We > should support as many as possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)