[
https://issues.apache.org/jira/browse/ARTEMIS-4668?focusedWorklogId=908591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908591
]
ASF GitHub Bot logged work on ARTEMIS-4668:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/24 15:47
Start Date: 06/Mar/24 15:47
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4840:
URL: https://github.com/apache/activemq-artemis/pull/4840#discussion_r1514721775
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPLargeMessageReader.java:
##########
@@ -34,7 +34,7 @@ public class AMQPLargeMessageReader implements MessageReader {
private final ProtonAbstractReceiver serverReceiver;
- private AMQPLargeMessage currentMessage;
+ private volatile AMQPLargeMessage currentMessage;
Review Comment:
@tabish121 , @gemmellr currentMessage is set to null as part of the Session
Executor.
We shouldn't have multiple threads messing with the variable at the same
time as we set readable to false and transfer the execution, but I think it
would be safer to set it as volatile.
Let me know if you have a concern here.
Issue Time Tracking
-------------------
Worklog Id: (was: 908591)
Time Spent: 7h 50m (was: 7h 40m)
> Move AMQP Large Message File Handling away from Netty thread
> ------------------------------------------------------------
>
> Key: ARTEMIS-4668
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4668
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.33.0
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Operations like file.open, file.close, and file.sync should be moved away
> from the Netty Thread for AMQP Large Messages
> This task now is about moving the processing for AMQP Messages. we may in a
> near future also improve tunneled large messages. For now we will do for AMQP
> messages only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
