[
https://issues.apache.org/jira/browse/ARTEMIS-4664?focusedWorklogId=908715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-908715
]
ASF GitHub Bot logged work on ARTEMIS-4664:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/24 10:56
Start Date: 07/Mar/24 10:56
Worklog Time Spent: 10m
Work Description: AntonRoskvist commented on code in PR #4836:
URL: https://github.com/apache/activemq-artemis/pull/4836#discussion_r1515958109
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -3919,7 +3919,10 @@ private void createResources(boolean isAutoCreate,
SimpleString destinationAddre
SimpleString destinationQueueName =
prefix.concat(getAddress()).concat(suffix);
SimpleString filter = new SimpleString(String.format("%s = '%s'",
Message.HDR_ORIGINAL_ADDRESS, getAddress()));
try {
- server.createQueue(new
QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true),
true);
+ Queue destinationQueue = server.createQueue(new
QueueConfiguration(destinationQueueName).setAddress(destinationAddress).setFilterString(filter).setAutoCreated(true).setAutoCreateAddress(true),
true);
+ if (destinationQueue != null && destinationQueue.isSwept()) {
+ destinationQueue.setSwept(false);
Review Comment:
Should be done now, hope it looks good... only thing I'm considering is if
the `setSwept` should be done before the `ignoreIfExists`-check instead of
after? Decided against it for now but I can change again if that makes sense.
Issue Time Tracking
-------------------
Worklog Id: (was: 908715)
Time Spent: 1h 20m (was: 1h 10m)
> autoCreatedResource can get removed while receiving batch of messages
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-4664
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4664
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There is a very small window where an auto created resource can get
> auto-removed while receiving a batch of new messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
